风青山

Results 83 comments of 风青山

1. The current `value` may be modified when setting the property `max`/`min`/`step`. The `step` value is not set first when loading, which causes the original `step` default value to still...

Both PRs are fine. This issue occurs even after reverting #67660. This is a matter of the order in which properties are set when instantiating a scene. If you need...

https://github.com/godotengine/godot/blob/e5cc494fbf4f5564c16d3deadb3a83a3c58b7546/editor/code_editor.cpp#L1009-L1012 Mainly related to this code. Although the L1010 takes much less time than the L1011, the lag is mainly caused by the aftereffect of the L1010. The after-effects of...

https://github.com/godotengine/godot/blob/bc88dca176cef6b8943ded58c68a60f7c127baea/scene/gui/tree.cpp#L4309-L4313 Same happens with `RichTextLabel` and `ItemList`. This is related to calling `RenderingServer::canvas_item_add_clip_ignore()`. Parent controls with `clip_contents` enabled cannot clip these borders.

The `owner` of internal nodes is usually not set, and the following code does not check if the owner is not set. https://github.com/godotengine/godot/blob/41365c6c8ba357a490ed924a128958240f3ccf04/scene/main/node.cpp#L2516-L2518 Nodes added through ~~**tool**~~ scripts may not...

The error message is a separate known issue if it appears during scene instantiation. During the instantiation of a scene, the instantiation of resources occurs before the instantiation of nodes....

#84824 solves the case when copying sub-scenes. The case here is the case of internal nodes in the same scene. Internal nodes are usually added when the parent node is...

Well, you are right, the script can manage the entire tree, possibly adding additional cases.

It appears to be a regression introduced by #89204. It seems to only crash when the scene root does not exist. https://github.com/godotengine/godot/blob/b2f425fe680d1ed5d5b5fa9ae289ae93fd294607/editor/plugins/canvas_item_editor_plugin.cpp#L5946-L5947 https://github.com/godotengine/godot/blob/b2f425fe680d1ed5d5b5fa9ae289ae93fd294607/editor/plugins/node_3d_editor_plugin.cpp#L4509-L4510

> @Rindbee so if `!scr->is_valid()`, then the error is usually that the file was not found? This usually means an error occurred in `GDScript::load_source_code()`. https://github.com/godotengine/godot/blob/3fa8fad26b97a8af20e7996b7e17d8f23fc04b89/modules/gdscript/gdscript_cache.cpp#L257-L261 Other than that, it's a...