Rikki Gibson

Results 153 comments of Rikki Gibson

Have finished reviewing ValueChecks. Will proceed on to the rest now but wanted to get these comments in.

we could also consider inserting a prereq job for the correctness jobs which runs on the hosted queues (i.e. has a fast queue time) and simply searches the set of...

Putting it directly above the statements would syntactically attach the attributes to the first top-level statement, which seems like a good thing to me. At that point it’s not clear...

Tangentially related to this: in https://github.com/dotnet/roslyn/issues/44571#issuecomment-659448287 we decided to make `/// ` tags above a record declaration apply to the primary constructor parameters, and for those elements to flow to...

@jaredpar brought up a scenario could break depending on how we implement this: ```cs class A : System.Attribute { public A(int i, string s) { } } class C {...

In this case, the correct behavior occurs with a lambda but not with a method group. It looks like your scenario behaves incorrectly with a lambda so probably a separate...

Yes, I wrote a bit about nullable analysis of semi-auto properties but decided to remove it from here and raise it separately, since it seems like it doesn't really depend...

Regarding the [conclusion](https://github.com/dotnet/csharplang/blob/main/meetings/2022/LDM-2022-02-14.md#conclusion) from LDM: > Proposal is accepted, contingent on following up with emeritus LDT members on original reasoning around struct definite assignment. We have followed up. We didn't...

> **Is this bug one of the reasons why SDKs < 6.0.200 were removed?** No. I'm not aware of why such SDKs were removed.