Rikki Gibson

Makes sense. I wasn't sure if you had written a prototype which uses publicly-exposed green nodes and benchmarked that to compare.

> ``` > var z = (any_expression = d); > ``` > > `z` would always be of the type of `d` and had the value of `d`. `d` is...

I think we probably have to block assignments to members of nullable structs for the same reason we block the following: [SharpLab](https://sharplab.io/#v2:EYLgtghglgdgPgAQMwAIDOAXATgVwMYYoDKAsAFADe5KNKydAjAAwoAKWA9gA4oUoDmAUwwBudMLEBfctLLl6CAEwoAwr2q0FAFhQBZABREA/OgCU6srSvoAdADUIAGxyCb7bigC8KAEQQfYgD0gSiCWJxYqkQMAGwMiiCqEDAwHIRgHAAmUABmAJ4oGAAWgnQA7CgAbk4uKBw5KADkxvY1go0owIJ4EDhopVCEUGgoqYQQVRBYUBDAjoIaNLKSQA===) ```cs public struct S { public string Prop...

I think it is not legal, because we don't define `??` as a conditional operation (i.e. something which is grouped under the right-side of a `?` operator, such as `.M()`...

Regarding https://github.com/dotnet/csharplang/issues/6045#issuecomment-1242414606 Thanks for the very interesting discussion. It feels like nullable value types and reference types are maybe experiencing an analogous issue here. [SharpLab](https://sharplab.io/#v2:EYLgtghglgdgNAFxBAzggPgWAFAGED8ABALICmCAFgPYAmAjABQGGwAOArggJQ4DeOhQYQACAdhYwOCQgHcolQr0IAzKKQA2NQgF5CAFgDMhAL4BuQgHoLsiACcYsAOYhCAcjadXhSAE9CwUkIYdnV1HGMcHABlIjJKWgAmBhiJKR5sfmwhEXEPBAA6ADUIdXZAuQUlVQ0tXUMTcysbeycXADkQ9QhgdUCANxKywgQfVkDff0Dg0PzwyOxbUgBjKlstXEURI1hpas1zCOw0W3Yl6SjN4W2YXbV9kxwgA) ```cs C? Method1(C? input) {...

It looks like a test baseline needs to be updated.

Thanks for the ping @Youssef1313. I think we should do a few checks before merging here. Other projects could get that same issue with WPF projects that we had to...

Have created a [test insertion](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6621353&view=results) (internal only) for this.

Would like to merge as soon as we can verify https://github.com/dotnet/wpf/issues/6792#issuecomment-1232270802.

I think we are good to go here since this should be going into RC1 at the same time as the WPF fix.