Rikki Gibson

Results 153 comments of Rikki Gibson

Got it, the return value is how values from the parameters might be captured.

Either before or at the same time that we do this, we should ensure that the test mentioned in https://github.com/dotnet/roslyn/pull/64152#discussion_r975898831 is updated to improve clarity.

I figured that case already had tests.

> I was previously wrong that we need to run suppressors after the parsing stage It wasn't clear to me why we don't want/need to do this. Are suppressible diagnostics...

It looks like the parsing stage can produce `WRN_PrecedenceInversion` which is presumably suppressible. Consider testing a case which has both `WRN_PrecedenceInversion` (you can search for that string to find examples...

Thanks for the ping @gohmiaoyu. Making a note to review once active development on .NET 7 winds down.

I think you're right. It looks like most of the non-actionable emails I used to get on that DL have stopped in recent times. Thanks!

> > The property declarations and their accessor declarations must have the same modifiers > > One thing I like about partial classes is that you can add a part...

> @RikkiGibson but it doesn't works for every modifier, I tried with abstract, but that doesn't work > > ```cs > public partial class C { > public abstract void...