Riken Shah

Results 17 comments of Riken Shah

> I think what would make sense to me is just having the message_scroll method, if it's loading message history for home_msg_list, additionally show the loading indicator for recent_topics; This...

But this would break `loading.make_indicator`, It expects an [`id` of the container element](https://github.com/zulip/zulip/blob/e976512b3cac919c32d278dd29fc7971896d09f2/static/js/loading.ts#L23). Maybe we could fix this by adding an extra argument `name` which will be used if `id`...

> Looks like it is trying to re-render on every scroll attempt. No, It does not render (fetch older messages) every time, only until the oldest messages are not loaded....

> The scrolling experience is awful for me. @amanagr Can you please explain what went wrong when you were scrolling? On my device scrolling looks alright, https://user-images.githubusercontent.com/63820270/125029838-d7d2aa80-e0a7-11eb-93e0-17762a629897.mov

Ohh got it, I updated the PR to load only when we scrolled to the bottom(~The last row is visible~ Scrolling is completed), instead of when scrolling. @amanagr Can you...

> What I see is that scrolling to the button using End seems to result in an infinite loop of loading, where it oscillates between showing the loading indicator and...

Looks like the above issue is related to https://chat.zulip.org/#narrow/stream/9-issues/topic/cursor.20position.20in.20Recent.20Topics/near/1231208.