vivint.py icon indicating copy to clipboard operation
vivint.py copied to clipboard

Published 20 hours ago • verified publisher icon Riebart

add carrier integration based on infinitive project

Open jgordon165 opened this issue 4 years ago • 4 comments

Provide carrier support based upon the infinitive project

https://github.com/acd/infinitive

jgordon165 avatar Oct 30 '20 17:10 jgordon165

This looks like it could either be a related repo/project, or it could live in a contrib portion of this library (since those that don't use a Carrier system would have no use for this, and this code doesn't directly touch any of the Vivint logic).

Thoughts?

Riebart avatar Nov 04 '20 02:11 Riebart

how would you represent the "contrib" portion? Like another folder?

jgordon165 avatar Nov 04 '20 03:11 jgordon165

how would you represent the "contrib" portion? Like another folder?

Yeah. Rearrange this into a proper Python module, and the Carrier stuff would life in vivint.contrib.carrier or similar, while the the main stuff would remain as vivint.PanelRoot. This has the benefit of giving semi-related stuff a nice home inside the project.

Riebart avatar Nov 04 '20 06:11 Riebart

good idea

jgordonpds avatar Nov 04 '20 06:11 jgordonpds