c-lightning-REST icon indicating copy to clipboard operation
c-lightning-REST copied to clipboard

Add partial_msat support for Core Lightning release v24.05

Open cloudsupper opened this issue 1 year ago • 1 comments

Summary by CodeRabbit

  • New Features
    • Added support for partial payments on invoices, allowing users to specify a partial payment amount. Note: Self-payment does not support this feature.

cloudsupper avatar Jun 12 '24 13:06 cloudsupper

Walkthrough

The payments.js file in the controllers directory has been updated to support partial payments for invoices. This enhancement allows users to specify an amount (partial_msat) that is less than the total invoice amount, though this feature is currently not available for self-payments.

Changes

File Path Change Summary
controllers/payments.js Added support for specifying a partial payment amount (partial_msat) when paying invoices. Self-payments do not support this feature.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PaymentsController
    participant InvoiceService

    User->>PaymentsController: Initiate Payment (invoice_id, partial_msat)
    PaymentsController->>InvoiceService: Fetch Invoice Details (invoice_id)
    InvoiceService-->>PaymentsController: Return Invoice Details
    PaymentsController->>InvoiceService: Process Partial Payment (partial_msat)
    InvoiceService-->>PaymentsController: Confirm Payment
    PaymentsController-->>User: Payment Confirmation

Poem

In the land of code, where payments flow, A partial sum can now bestow. 🐇✨ No need to pay the whole in one, Just a part, and you are done. For invoices, this change is neat, Making payments quite a treat!

[!WARNING]

Review ran into problems

Problems (1)
  • Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 12 '24 13:06 coderabbitai[bot]