RTL icon indicating copy to clipboard operation
RTL copied to clipboard

Allow alternate location for log file

Open jpentland opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. It does not always make sense for log files to be in the same location as the config files. E.g. if the config file were to be placed at /etc/RTL/RTL-Config.json.

Describe the solution you'd like Allow overriding the log directory location, either via environment variable, command line flag, or somewhere in the config file.

Additional context Config file location is currently set via the environment variable RTL_CONFIG_PATH and is used for both the config file path and log file path.

jpentland avatar Jul 19 '22 15:07 jpentland

Steps to make log file path configurable:

  • Add logFilePath in RTL-Config.json node's setting.
  • This logFilePath setting should be configurable/editable through the UI.
  • Add LOG_FILE_PATH in environment variable.
  • Environment variable should take precedence over config file.
  • Maintain current path as default log path.
  • If RTL fails to gain write access on the folder, show warning message to the user and fallback to default logging path.

ShahanaFarooqui avatar Oct 06 '22 19:10 ShahanaFarooqui

  • This logFilePath setting should be configurable/editable through the UI.

we should be careful in making the logFilePath configurable via the UI, lest it opens up the app to LFI vulnerability

saubyk avatar Oct 08 '22 21:10 saubyk

UI should not use file explorer for configuration/update. It should be a text input field.

ShahanaFarooqui avatar Oct 08 '22 22:10 ShahanaFarooqui