Grant Millar

Results 89 comments of Grant Millar

> @cpuguy83 Are you doing remap on the daemon or container level? I'm not sure if it makes a difference but we're doing the remap on the daemon. @cpuguy83 would...

I'm also having the same issue with the same setup.

It looks like the tests are also outputting incorrect code. @Korbeil Can you take a look at the fix, if you think it looks good, I can update the tests....

Thanks @Korbeil, I'll fix the tests this or next week and then you can merge.

@Korbeil I've fixed the tests, but it does not resolve @achton's issue. We should check if the value is null at runtime and pass it as null instead of an...

Here's what it might look like if we test for null: ```php /** * @return array|string|int|float|bool|\ArrayObject|null */ public function normalize($object, $format = null, array $context = array()) { $data =...

@Korbeil I've updated to handle the above and fixed the tests. If you agree with the changes I will squash the commits.

@Korbeil I've updated the CHANGELOG and squashed the commits into one. This closes: https://github.com/janephp/janephp/issues/700 https://github.com/janephp/janephp/issues/680

@thePanz happy to rebase, do you have merge permissions?