NSwag icon indicating copy to clipboard operation
NSwag copied to clipboard

IsDateTime should return true when using Moment (see NjsonSchema) #1613

Open bjarne-callewaert opened this issue 8 months ago • 0 comments

This is a follow-up for PR #3660.

When using Moment, the TimeSpan class is not converted to the correct format when it is part of the url parameters. Nswag doesn't append the .format('d.hh:mm:ss.SS', { trim: false }) method on TimeSpans, while in NjsonSchema, this is done correctly. This causes TimeSpans to be converted to Moments differently when used in the url parameter or in the body.

The source of this issue lies in the fact that in NjsonSchema, the IsDateTime function returns true when a TimeSpan is used (NJsonSchema.CodeGeneration.TypeScript/DataConversionGenerator.cs). In Nswag this was not yet the case, so this was added in this PR.

Kind regards, Bjarne

bjarne-callewaert avatar Jun 13 '24 13:06 bjarne-callewaert