feedback icon indicating copy to clipboard operation
feedback copied to clipboard

Add cancel dialog event listener & Export FeedbackService, FeedbackDirective

Open workfel opened this issue 4 years ago • 4 comments

  • I need service to force re-render the screenshot, because before set screen image i need to hide all private user information.

workfel avatar Nov 20 '19 09:11 workfel

@workfel I think it would be great to make another service specifically for export. It should have only one method feedback(): Observable<Feedback>, which, if successful, returns Feedback, and if canceled, returns an error. This will allow you to use this library with any buttons and directives, not just the built-in one, and it will not force the user to deal with the internal organization of the initScreenshotCanvas, setFeedback, openFeedbackDialog, etc. methods.

artar94 avatar Dec 23 '19 08:12 artar94

ok, but why don't juste export the current Service ?

workfel avatar Dec 23 '19 11:12 workfel

I have nothing against it, but I would recommend at least renaming the current FeedbackService to FeedbackInternalService so that the new service has a user-friendly name.

artar94 avatar Dec 23 '19 12:12 artar94

Ok, i just updated the PR

workfel avatar Dec 23 '19 12:12 workfel