lein-tools-deps icon indicating copy to clipboard operation
lein-tools-deps copied to clipboard

Published 20 hours ago • verified publisher icon RickMoynihan

make it work on windows

Open markus-wa opened this issue 4 years ago • 9 comments

This PR makes lein-tools-deps work on windows.

see also #85

~~NOTE: clojure.bat needs to exists on the PATH:~~ NO LONGER REQUIRED WITH LATEST CHANGES

@ECHO OFF
call powershell.exe -c "clj %*"

~~TODO:~~ done

  • [x] add note in README regarding windows
  • [x] fix failing tests on windows

markus-wa avatar Mar 22 '20 12:03 markus-wa

Maybe we could do something like cmd /c "powershell.exe -m clojure ... instead of requiring clojure.bat will give it a go when I'm back on a windows machine at some point.

markus-wa avatar Mar 25 '20 12:03 markus-wa

@RickMoynihan I've made some changes according to your suggestions.

  • use 'powershell -c' to invoke Clojure CLI Tools when on windows (this means we no longer need clojure.bat!)
  • comment about backslashes
  • made tests run on windows
  • added section to README

markus-wa avatar Mar 28 '20 19:03 markus-wa

@RickMoynihan let me know if there's anything else I can do for this PR :slightly_smiling_face:

markus-wa avatar May 31 '20 02:05 markus-wa

@markus-wa thanks sorry I'd missed the notification on this repo. Will try to find some time to take a look at it and think it through.

At a quick glance the changes look reasonable, but my main problem is I don't use windows, or have the time to test it there myself.

Having some automated tests on windows would be useful to prevent any regressions, and help ensure this was maintained. I'd rather not mix that with this PR though, that could be added after this PR if someone would be willing to contribute such a thing.

RickMoynihan avatar Jun 03 '20 09:06 RickMoynihan

Thanks for the updates... will try and find some time to think it through and get this merged.

RickMoynihan avatar Jun 04 '20 10:06 RickMoynihan

Awesome, cheers @RickMoynihan

Btw, I played around with windows builds on travis yesterday but it seems like it's not yet working for clojure. The build just errored before even booting the runner.

markus-wa avatar Jun 04 '20 11:06 markus-wa

Any update on this? I tested this locally on Windows and seems to work like a charm.

:middleware [lein-tools-deps.plugin/resolve-dependencies-with-deps-edn]

terohe avatar Nov 10 '20 07:11 terohe

no idea @terohe - I switched to Linux in the meantime tbf, but would still be cool to see this merged @RickMoynihan

markus-wa avatar Nov 17 '20 18:11 markus-wa

Hi,

I don't actually use lein-tools-deps anymore and I'm conscious that tools.deps itself has changed quite a lot recently to support different aliases. So I don't feel like I'm the best maintainer for this project anymore.

If the project is still useful to people I'd be happy to see someone fork and maintain the project.

RickMoynihan avatar Nov 18 '20 11:11 RickMoynihan