Ricin icon indicating copy to clipboard operation
Ricin copied to clipboard

Copying entire friend ID via custom_packets.

Open SkyzohKey opened this issue 9 years ago • 12 comments

A user should be able to copy friends ToxID. To achieve this I think it would be nice to use the custom_packets "method" provided by ToxCore.

Example:

  • Alice right click Bob FriendListRow and click on "Ask for ToxID" ;
  • Alice client send a friend_request_toxid packet to Bob ;
  • Bob is asked for sending his entire ToxID (not only the pubkey) ;
    • If Bob answer by Yes his client send a friend_response_toxid containing it's ToxID ;
    • If Bob answer by No his client send a friend_response_toxid containing null or false.
  • Alice client get notified of the friend_response_toxid and can:
    • Copy Bob ToxID in the Clipboard ;
    • Notify Alice that Bob rejected her request to get Bob entire ToxID.

Extra: It should be possible to auto-accept friend_request_toxid but this should be disabled by default.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

SkyzohKey avatar Oct 18 '15 13:10 SkyzohKey

why do you need the other friend's ToxID

benwaffle avatar Oct 18 '15 13:10 benwaffle

It's sometimes useful to have friend ID, for example when you want to add it on another client/computer. Or if a friend demands you the ToxID of another friend ^^

SkyzohKey avatar Oct 18 '15 13:10 SkyzohKey

I believe @subliun is doing something similar for Antox, you should use the same method and be compatible.

ProMcTagonist avatar Oct 18 '15 16:10 ProMcTagonist

ah, nice! @subliun could you talk here about what you did, in order to make Ricin compatible, and maybe adding this in the Tacos/Tox-STS :3

SkyzohKey avatar Oct 18 '15 18:10 SkyzohKey

Great idea. Came here from Tox group chat. As a regular Tox user who's been trying to get his friends to use it for a year now(with limited success), I say every Tox client should have this feature. If it can be, it'd be nice if this would be supported in toxcore. One of the most annoying things right now is adding friends of friends. You have to either keep a database of friend IDs like I do, or ask them when they happen to be online.

Doom032 avatar Oct 18 '15 21:10 Doom032

I'd like to have such feature. I hate when I have to add every friend's id manually on my phone.

FoundOne avatar Oct 18 '15 21:10 FoundOne

https://github.com/subliun/Antox/issues/134

benwaffle avatar Oct 21 '15 22:10 benwaffle

@subliun any news about what you did for Antox ?

SkyzohKey avatar Nov 07 '15 06:11 SkyzohKey

Wouldn't it be nice to have some kind of contact sharing? This could be relatively trivially implemented by displaying a suggestion to make a friend request when someone sends you a Tox ID. Additionally, we could implement a "share contact" button that would automatically ask for another contacts Tox ID (as suggested above) and paste it into the current conversation.

codedust avatar Apr 12 '16 22:04 codedust

@codedust Yep, should be doable i guess. Can you open an issue for this suggestion please ? x)

SkyzohKey avatar Apr 12 '16 22:04 SkyzohKey

Done ;)

codedust avatar Apr 12 '16 22:04 codedust

You can implement it using plugins like I did in my client (https://github.com/ingvar1995/toxygen_plugins/tree/master/CopyableToxId)

IngvarX avatar Jul 29 '16 13:07 IngvarX