Richard Tweed

To clarify as well, despite this accepting values, the chip *should* have a resistor which also caps the charging current, and the charging chip uses the lower of the two...

A bit more context CVSS 4 score 6.8 CVSS:4.0/AV:L/AC:L/AT:N/PR:L/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N Affected versions: Every version since at least the following commit for the log issue. I stopped my git search at this...

I can't trigger a rerun for these tests, but they're complaining with `Interrupted by Other Ginkgo Process ` which seems unrelated to this change

It would be nice if we could add a test to prevent regressions here, but I'm not sure where best to add a test for the format of a generated...

> Could you please remove changes, which are not relevant to the actual purpose of your PR? That also re-triggers CI. Of course, sorry about that. my IDE autoformatted 🤦

> Also keep in mind that users, that want to change this and prevent sensitive information from being logged, can also do this by configuring their own logging format. Yes,...

Ah, the tests broke as they're asserting based on information in the logs "log does not contains id=dummy_log_splitter_foo_bar" How would you prefer these being fixed?

This is optional, but all users would get it by default because the current "log sensitive information by default" isn't a great default in my opinion. Users can override back...

>You can help current users NOT experience a change, regardless of opinions, and make the use of your change optional. Please consider that forced opt-in is something that the project...

If users want to use their own custom format, either before or after this change they can set the following in their values.yaml Their existing custom logging configuration is unaffected...