Trevor N. Suarez

Results 89 comments of Trevor N. Suarez

I wouldn't mind taking a pull request if you wanted to show how you might implement this feature. Otherwise, implementing it in your own project is easily done without having...

Wow! This is unreal! Thank you so much @eimajenthat! I don't have time to look at this right now, but I'll definitely be taking a look at it soon! Thanks...

@jinora this is a great pull request! I appreciate you including tests also. A few things though. I'll comment on the code lines where appropriate. Otherwise, HTTP caching requires many...

Hmm, strange. Are you making sure to actually send the response after setting the code? The `onError()` handlers are called when a "stop the world" exception is caught, so you...

Yea, Klein should be sending the response no matter what, but its hard to tell with just your snippet. If you're rethrowing the exception anywhere or somehow skipping the rest...

There really kind of is. :) The `$request->param()` and `$request->params()` methods are just convenience methods that merge together all of the possible parameter locations. As you said, the `paramsGet()` method...

Interesting. The error you're getting is referring to the `markdown()` method in the ServiceProvider, as you can see here: https://github.com/chriso/klein.php/blob/6e1f228ce82333b437402dafad049713eb3eeac6/Klein/ServiceProvider.php#L239 I don't see where you are calling `markdown()` in your...

Ah ha! I see why the error is happening. If you pass a string to `markdown()` it calls `vsprintf()`. Since the `printf()` family of functions use `%x` (where `x` is...

Hmm, the problem is that escaping the `%` signs means it'll no longer allow for template string parsing. Its a regression. I won't be able to release this without a...

For reference: http://stackoverflow.com/questions/3666734/php-sprintf-escaping