Project-Poseidon
Project-Poseidon copied to clipboard
RhysB
Buffer Writes
https://github.com/PaperMC/Paper/blob/ver/1.8.8/CraftBukkit-Patches/0158-Optimize-Chunk-Saving-Memory-Allocation-and-Compress.patch Wrap the output stream w/ BufferedOutputStream to get improved I/O performance.
Hey mate,
Just confirming you have done testing with this patch?
Indeed but the benchmarks I did were quite rudimentary with no profiler involved (measuring the time it took to run this function) Instead of merging this I would like to make a proposition of copying these patches [1] [2] from canyon as they've clearly had a lot more thought and testing put into them.
@idealth As you still working on the other patches or are you just wanting me to merge this one?
@idealth As you still working on the other patches or are you just wanting me to merge this one?
I apologize but I don't know how to go about merging the commits made in canyon, to copy MIT-licensed code I believe that you have to include their license (not that you have to license your code as MIT). I have no clue where you would want that to be placed.
@idealth As you still working on the other patches or are you just wanting me to merge this one?
I apologize but I don't know how to go about merging the commits made in canyon, to copy MIT-licensed code I believe that you have to include their license (not that you have to license your code as MIT). I have no clue where you would want that to be placed.
I'm pretty sure you can just make a separate package name and add a LICENSE.txt there.
