ObjectTransport icon indicating copy to clipboard operation
ObjectTransport copied to clipboard

Sending multiple objects one after each other breaks the client

Open Skyhikeeper opened this issue 7 years ago • 5 comments

When I send objects one after each other the client cannot handle the events, it seems to concatenate all the objects into one and then the event does not fire correctly.

Skyhikeeper avatar Dec 10 '18 17:12 Skyhikeeper

Hi Skyhikeeper,

Thanks for reporting this. I'm working on it and adding a few more unit tests to cover this. This will be resolved by the end of the week.

Regards, Rhyno

RhynoVDS avatar Dec 12 '18 00:12 RhynoVDS

Hi Rhyno

Any news on this fix that will generate an event on each object received and not concatenate everything into one message, which is then not identifiable.

Regards

Terence

From: Rhyno van der Sluijs [email protected] Sent: Wednesday, 12 December 2018 2:00 AM To: RhynoVDS/ObjectTransport [email protected] Cc: Skyhikeeper [email protected]; Author [email protected] Subject: Re: [RhynoVDS/ObjectTransport] Sending multiple objects one after each other breaks the client (#14)

Hi Skyhikeeper,

Thanks for reporting this. I'm working on it and adding a few more unit tests to cover this. This will be resolved by the end of the week.

Regards, Rhyno

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RhynoVDS/ObjectTransport/issues/14#issuecomment-446409533 , or mute the thread https://github.com/notifications/unsubscribe-auth/AoYDAoAmEPC4G4AoALWupPqNqMtux6T-ks5u4EcLgaJpZM4ZL1xE . https://github.com/notifications/beacon/AoYDAto2P9FzzErKWOmAKENfFHldIXFTks5u4EcLgaJpZM4ZL1xE.gif

Skyhikeeper avatar Dec 17 '18 11:12 Skyhikeeper

With the targetted .net framework and .net core there are some limitations for creating a clean solution. However, I have a working solution to this but I need to write more unit tests to ensure that everything is ok. All 45 unit tests are green but I would like to write more thorough ones around this area.

You could in the mean time do a Thread.Sleep(50) before each send. You may need to make the thread sleep for longer and could make the thread sleep for less. Let me know how that goes.

RhynoVDS avatar Dec 18 '18 01:12 RhynoVDS

I have added the thread sleep, it solves one issue and creates more problems, as it does not solve the problem, I have a high volume sight that send a lot of objects to other clients and I need to make sure that every message is received and none lost.

Skyhikeeper avatar Jan 21 '19 17:01 Skyhikeeper