silverstripe-cms-theme icon indicating copy to clipboard operation
silverstripe-cms-theme copied to clipboard

Wrong title display within subnav CMS4.12

Open BettinaMaria98 opened this issue 2 years ago • 5 comments

Hello, we are using silverstripe with CMS 4.12.0@stable and got a wrong display within the submenu (We use Tag 3.4.5 of silverstripe-cms-theme):

grafik

If we change $SectionTitle to $Title within vendor/ryanpotter/silverstripe-cms-theme/templates/SilverStripe/Admin/Includes/LeftAndMain_MenuList.ss at line 32 it is displayed correctly. I've seen that the change was made within a pull request in May 2023: https://github.com/Rhym/silverstripe-cms-theme/commit/44a15b6a071bd36c57d0a72ecb0e3d141e5a86d0 Maybe there is some difference between CMS5 and CMS4.12? Would it be possible to add a tag or something for 4.12 here?

BettinaMaria98 avatar Sep 05 '23 12:09 BettinaMaria98

Until a fix is made, you should be able to use the previous tag.

Rhym avatar Sep 05 '23 19:09 Rhym

@Rhym perfect, thank you!

BettinaMaria98 avatar Sep 06 '23 07:09 BettinaMaria98

@Rhym I'm on "silverstripe/recipe-cms": "~5.0.0@stable", and have "ryanpotter/silverstripe-cms-theme": "dev-master" installed, however my titles aren't rendering. Do I need to override LeftAndMain_MenuList.ss in my templates folder? If so where should I be placing it?

Update: The only way I got it to work was to override the templates/SilverStripe/Admin/Includes/LeftAndMain_MenuList.ss … so placing it in my app/templates/SilverStripe/Admin/Includes/LeftAndMain_MenuList.ss, if anyone is wondering.

zaidaldabbagh avatar Sep 15 '23 04:09 zaidaldabbagh

Why was $Title changed to $SectionTitle?

RVXD avatar Oct 12 '23 07:10 RVXD

Could we get a new version tag with this fix pls :)

matt-in-a-hat avatar Mar 03 '24 23:03 matt-in-a-hat