Webcharts

Webcharts copied to clipboard

samussiah

https://github.com/RhoInc/Webcharts/blob/f4932c2e2ebed32257e209c4945b59af5b2e5628/src/multiply.js#L15

samussiah

# Issues Closes #259

samussiah

maybe write a few more for the v1.11.7 issues

samussiah

Move legend styling to .css file rather than defining inline.

1

See [makeLegend](https://github.com/RhoInc/Webcharts/blob/master/src/chart/makeLegend.js) lines 30, 41, and 80.

samussiah

text marks not supported in legend

3

It might actually be more that the combination of text and non-text marks is breaking ...

jwildfire

like [charts](https://github.com/RhoInc/Webcharts/blob/master/src/createChart.js#L51). issue arises in [makeRadioControl](https://github.com/RhoInc/Webcharts/blob/master/src/controls/makeRadioControl.js#L14) because [two radio inputs with the same _name_ attribute don't cooperate](https://stackoverflow.com/questions/30791791/multiple-radio-button-groups-with-same-name).

samussiah

Table: Sort by integer for numeric values

3

On the gist, when sorting a numeric column, it appears to sort by treating the numbers as characters not integers: 

rtbailey

for example, sort by any column [here](https://rhoinc.github.io/Webcharts/test-page/createTable/) and remove the sort - the table order doesn't change

samussiah

Grouped bars sort in the reverse of chart.config.legend.order.

1

i.e. the bar and the legend are mirrors.

samussiah