Webcharts icon indicating copy to clipboard operation
Webcharts copied to clipboard

Avoid selecting SVG elements without class names in updateDataMarks.

Open samussiah opened this issue 5 years ago • 1 comments

for instance in drawBars:

if any custom rect elements are added to these bar groups the new and original elements behave unpredictably

samussiah avatar Apr 02 '19 20:04 samussiah

Hmm. Makes sense, but also seems like a bit of an edge case, since I'm not sure if we've ever manually added rects to a bargroup. Marking low priority unless you disagree, @samussiah.

I guess easy solution would be to give the webcharts rect objects used in the code above a specific class, and then use it in those selectors. Or better yet, use marks[].rect.

jwildfire avatar Nov 18 '19 16:11 jwildfire