proxmark3 icon indicating copy to clipboard operation
proxmark3 copied to clipboard

OLD -> NG frames

Open iceman1001 opened this issue 3 years ago • 1 comments

The convertion process to switch to NG-frame format, via MIX, has these following instances left of the OLD usage on client side.

rg -i 'SendCommandOld'

  • [x] cmdflashmem.c
  • [x] cmdflashmemspiffs.c
  • [ ] cmdhf14a.c
  • [x] cmdhfcryptorf.c
  • [ ] cmdhfepa.c
  • [x] cmdhflegic.c
  • [ ] cmdhficlass.c
  • [x] cmdhfmfu.c
  • [ ] cmdhftopaz.c
  • [ ] cmdlfhitag.c
  • [x] cmdsmartcard.c
  • [ ] mifare/mifarehost.c
client/src/cmdhf14a.c
802:  SendCommandOLD(CMD_HF_ISO14443A_READER, ISO14A_RAW | ISO14A_APPEND_CRC | cmdc, (datainlen & 0xFFFF) + 2, 0, data, (datainlen & 0xFFFF) + 2);
932:  SendCommandOLD(CMD_HF_ISO14443A_READER, ISO14A_APDU | ISO14A_NO_DISCONNECT | cmdc, (datainlen & 0x1FF), 0, datain, datainlen & 0x1FF);
1288: SendCommandOLD(CMD_HF_ISO14443A_READER, flags, (datalen & 0xFFFF) | ((uint32_t)(numbits << 16)), argtimeout, data, datalen & 0xFFFF);

client/src/cmdhftopaz.c
57:   SendCommandOLD(CMD_HF_ISO14443A_READER, ISO14A_RAW | ISO14A_NO_DISCONNECT | ISO14A_TOPAZMODE | ISO14A_NO_RATS, len, 0, cmd, len);

client/src/cmdhfepa.c
163:  SendCommandOLD(CMD_HF_EPA_REPLAY, i + 1, j * sizeof(data), packet_length, data, packet_length);

client/src/cmdhficlass.c
2975: SendCommandOLD(CMD_HF_ICLASS_CHKKEYS, flags, keys, 0, pre + key_offset, 4 * keys);
3144: SendCommandOLD(CMD_HF_ICLASS_CHKKEYS, flags, keys, 0, pre + key_offset, 4 * keys);

client/src/cmdlfem4x50.c
194:  SendCommandOLD(CMD_LF_EM4X50_ESET, i, len, 0, src + i, len);

client/src/cmdlfhitag.c
668:  SendCommandOLD(CMD_LF_HITAGS_TEST_TRACES, 1, 0, 0, data, datalen);

client/src/mifare/mifarehost.c
204:  SendCommandOLD(CMD_HF_MIFARE_CHKKEYS_FAST, (sectorsCnt | (firstChunk << 8) | (lastChunk << 12)), ((use_flashmemory << 8) | strategy), size, keyBlock, 6 * size);

MFU uses MIX now.

iceman1001 avatar Oct 03 '20 17:10 iceman1001

legic now uses NG. I also removed OLD from scripting, since there is no OLD used in any lua scripts.

iceman1001 avatar Feb 14 '22 08:02 iceman1001

Only OLD left is in bootrom, comms and one instance in mifarehost

client/src/mifare/mifarehost.c
231:    SendCommandOLD(CMD_HF_MIFARE_CHKKEYS_FAST, (sectorsCnt | (firstChunk << 8) | (lastChunk << 12)),......

iceman1001 avatar Jan 26 '24 22:01 iceman1001