proxmark3 icon indicating copy to clipboard operation
proxmark3 copied to clipboard

Properly handle "hf mf dump" errors

Open gsingh93 opened this issue 4 months ago • 4 comments

I was confused why hf mf dump wasn't showing any errors but the dump file was all zeros:

[usb|script] pm3 --> hf mf dump
[+] time: 0 seconds

[+] saved 1024 bytes to binary file `/Users/gsgx/hf-mf-D6E6ACDF-dump-001.bin`
[+] saved to json file `/Users/gsgx/hf-mf-D6E6ACDF-dump-001.json`

For some reason PM3_SUCCESS was being returned from this error path, and the log message was using the DEBUG log level. After this PR, it's more clear an error occured:

[usb|script] pm3 --> hf mf dump
[-]  iso14443a card select failed

gsingh93 avatar Feb 16 '24 01:02 gsingh93