proxmark3 icon indicating copy to clipboard operation
proxmark3 copied to clipboard

New 'lf hitag pwmdemod' cmd decoding the reader messages from graph b…

Open codeflakes0 opened this issue 4 years ago • 3 comments

This new command is based on the 'data rawdemode' commands. It is intended to be used on graph buffer data captured with a previous 'lf search' Since the decode is done in variable bit range I've had to modify proxguiqt.cpp to take into account. Not sure if this was the best way to deal with this problem. There is a know bug when zooming and scrolling, the displayed demodulation bits are shifted and do not follow the signal.

codeflakes0 avatar Oct 05 '21 14:10 codeflakes0

hm.. interesting.. maybe it should have been under data pwm and not under hitag. Not sure about the graph buffer doing. the normal way is to copy it to your local array, put all demods into the demod array... and thats it.

iceman1001 avatar Oct 06 '21 17:10 iceman1001

Yes I though of adding the feature to the data cmd too as it's a very generic command. You decide. The graph buffer I added was necessary because with this type of decode the period is not constant so the demodulation was not displaying correctly of top of the signal. It was progressively pushed too far on the right. But it is entirely possible this was not necessary and I just did not understand the graph code enough.

codeflakes0 avatar Oct 18 '21 09:10 codeflakes0

You are welcome to add an entry to the CHANGELOG.md as well

github-actions[bot] avatar Oct 22 '21 13:10 github-actions[bot]