Thrive icon indicating copy to clipboard operation
Thrive copied to clipboard

Fix error log from glaciation event

Open 0HyperCube opened this issue 8 months ago • 1 comments

Brief Description of What This PR Does The finish event code now iterates over the modified patches and prints an error if they are no longer in the world.

Previously it would iterate through all the patches in the world and print and error if they weren't modified. This occurred for all non-surface patches.

Related Issues Closes #6158

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • [x] PR author has checked that this PR works as intended and doesn't break existing features: https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist (this is important as to not waste the time of Thrive team members reviewing this PR)
  • [ ] Initial code review passed (this and further items should not be checked by the PR author)
  • [ ] Functionality is confirmed working by another person (see above checklist link)
  • [ ] Final code review is passed and code conforms to the styleguide.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

0HyperCube avatar Jun 08 '25 20:06 0HyperCube

The lead programmer for Thrive is currently on vacation until 2025-07-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed.

PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged.

revolutionary-bot avatar Jun 08 '25 20:06 revolutionary-bot