Thrive icon indicating copy to clipboard operation
Thrive copied to clipboard

Closing modal on "Next" pressed in editors

Open CoreyHendrey opened this issue 1 year ago • 2 comments

Brief Description of What This PR Does

Editors will now attempt to close all their open modals before continuing. It will not let the editor continue if there is an exclusive modal open that refuses to close.

Closes #4470

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • [x] PR author has checked that this PR works as intended and doesn't break existing features: https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist (this is important as to not waste the time of Thrive team members reviewing this PR)
  • [ ] Initial code review passed (this and further items should not be checked by the PR author)
  • [ ] Functionality is confirmed working by another person (see above checklist link)
  • [ ] Final code review is passed and code conforms to the styleguide.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

CoreyHendrey avatar Sep 21 '23 02:09 CoreyHendrey

We are currently in feature freeze until the next release. If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

revolutionary-bot avatar Dec 08 '23 13:12 revolutionary-bot

What's the status on this? As far as I can quickly see my latest review comments weren't addressed yet.

hhyyrylainen avatar Aug 02 '24 09:08 hhyyrylainen