Thrive icon indicating copy to clipboard operation
Thrive copied to clipboard

Max species name size

Open Kiloku opened this issue 2 years ago • 1 comments

Brief Description of What This PR Does

This PR keeps the species name limited to a size based on the line-edit field's width, rather than limiting it to a certain number of characters. This is achieved through Godot's GetStringSize function, in the Font class.

Related Issues

Resolves #2968

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • [x] PR author has checked that this PR works as intended and doesn't break existing features: https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist (this is important as to not waste the time of Thrive team members reviewing this PR)
  • [ ] Initial code review passed (this and further items should not be checked by the PR author)
  • [ ] Functionality is confirmed working by another person (see above checklist link)
  • [ ] Final code review is passed and code conforms to the styleguide.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

Kiloku avatar Aug 03 '22 21:08 Kiloku

Thank you for contributing to Thrive.

Before your contribution can be accepted, you need to sign our CLA. You can sign it, and find more info about it, here: https://dev.revolutionarygamesstudio.com/cla

Once your contribution has been accepted you can ask to be included in the credits (https://wiki.revolutionarygamesstudio.com/wiki/Team_Members) and you can apply to join the team and use this work as a sample: https://revolutionarygamesstudio.com/application/

revolutionary-bot avatar Aug 03 '22 21:08 revolutionary-bot