Add max spawned entities option to the new game settings

[athariqk]

Brief Description of What This PR Does

Added max spawned entities option to the new game settings as per my forum post https://forum.revolutionarygamesstudio.com/t/increasing-game-performance/841/12.

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

• [x] PR author has checked that this PR works as intended and doesn't break existing features: https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist (this is important as to not waste the time of Thrive team members reviewing this PR)
• [ ] Initial code review passed (this and further items should not be checked by the PR author)
• [ ] Functionality is confirmed working by another person (see above checklist link)
• [ ] Final code review is passed and code conforms to the styleguide.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

[Oliveriver]

I'm afraid I still really don't think this fits with the other new game settings. It's jarring to have to set something that's attached to the program as a whole rather than a particular game alongside many game-specific things. Plus, it makes the basic view more complicated and intimidating.

I'm still in favour of having some kind of popup (or if that's too intrusive, a text tip) in the main menu or game prompting players to set the option in the options menu, perhaps with a button linking it. It could be shown only once, or have a checkbox to not show again like the tutorial popup.

But if I am overruled, in terms of this implementation: this duplicates code from the options menu and sets the entity limit without the player giving any kind of confirmation. The text hint also spans two lines, which doesn't look great.

[hhyyrylainen]

Maybe just a bit of text in the simple new game options saying that "you can change performance related options at any time in the options menu to improve game performance"?

[athariqk]

Sounds like a good compromise.

[athariqk]

I've now added that text to the bottom of the new game settings menu. It also links to the options menu which can be clicked to open performance options.

[hhyyrylainen]

@Oliveriver can you recheck this please?

[Oliveriver]

Definitely a lot better. The highlighted text link is a bit odd as I don't think we do that anywhere else, and it's annoying to click back from options and return to the main menu rather than the new game settings. But both of those are minor and probably more trouble to fix than they're worth.

[hhyyrylainen]

The highlighted text link is a bit odd

The Steam uploader dialog at least has a clickable link to open the TOS. Does this use the same colours etc.?

[athariqk]

I don't recall the one used by TOS link but for this one I use aqua color, which I think looks the best.

[hhyyrylainen]

Here's how it looks:

It also reacts to the cursor being over it by turning into the clickable cursor.

[athariqk]

Hm, the text font and the buttons size in that popup really needs some tweaking... Anyway, I guess I'll change the color to that for consistency then, and yes cursor will always change to the clickable cursor automatically for any [url] bbcode.

[hhyyrylainen]

and yes cursor will always change to the clickable cursor automatically for any [url] bbcode.

I hadn't looked at the code so I wasn't sure yet how you'd implemented it, but it's good to hear that you used the way I would have approached it.