Thrive icon indicating copy to clipboard operation
Thrive copied to clipboard

Defer a call for adding phagosome node to engulfed objects when loading a save

Open athariqk opened this issue 2 years ago • 1 comments

Brief Description of What This PR Does

Defer a call for adding phagosome node to engulfed objects when loading a save

Related Issues

Fixes #3579

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • [x] PR author has checked that this PR works as intended and doesn't break existing features: https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist (this is important as to not waste the time of Thrive team members reviewing this PR)
  • [ ] Initial code review passed (this and further items should not be checked by the PR author)
  • [x] Functionality is confirmed working by another person (see above checklist link)
  • [ ] Final code review is passed and code conforms to the styleguide.

Before merging all CI jobs should finish on this PR without errors, if there are automatically detected style issues they should be fixed by the PR author. Merging must follow our styleguide.

athariqk avatar Jul 27 '22 08:07 athariqk

Just made it so that node reattaching is ignored if it already is. May need another testing to see nothing is amiss @RacerBG.

athariqk avatar Jul 28 '22 06:07 athariqk

@Kasterisk do you think you would have time soon to add a few comments into this PR as with them I'd be ready to merge this?

hhyyrylainen avatar Aug 17 '22 11:08 hhyyrylainen

I will in a moment, I forgot I opened this PR.

athariqk avatar Aug 17 '22 11:08 athariqk