ReviewNB
No green highlighting for newly added notebooks!
Problem
We highlight newly added diff lines in green, it's super useful when comparing two versions of a notebook.
ReviewNB users often review fresh / newly added notebooks in a pull request. Currently, we apply a green color highlight to ALL the lines in a newly added notebook. This excessive highlighting serves no purpose & actually diminishes readability (see screenshot at the end).
Users have also raised concerns about this.
Solution
For newly added notebooks, we are introducing a more effective approach. Instead of highlighting the entire notebook, we will display a small information box at the top, notifying users that it's a newly added notebook (see screenshot).
FAQ
-
Why not remove highlighting from a deleted notebook? Users typically don't extensively review deleted files, so readability isn't a significant concern here. The pink highlighting acts as a visual cue (telling users that it's a deleted notebook), guiding users to proceed to more review-worthy parts of the PR.
-
Why not remove highlighting from diffs / changes? Background highlighting remains valuable when comparing two notebook versions. It effectively directs users' attention to specific changes that need reviewing, thus aiding the review process.
