purchases-ios icon indicating copy to clipboard operation
purchases-ios copied to clipboard

Add Purchases.shared.attribution.setAmplitudeUserId to the SDK

Open alpennec opened this issue 10 months ago • 4 comments

Hello,

Can you update the SDK to add a method to set the UserID/DeviceID instead of having to use the reserved attribute $amplitudeDeviceId or $amplitudeUserId ourselves?

https://www.revenuecat.com/docs/integrations/third-party-integrations/amplitude

Thanks, Axel

alpennec avatar Feb 07 '25 15:02 alpennec

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

RCGitBot avatar Feb 07 '25 15:02 RCGitBot

Hey Axel! Thanks for the feedback. Are you picturing something like the helper method collectDeviceIdentifiers but that will gather available IDs for integrations?

kmurphy-rc avatar Feb 11 '25 16:02 kmurphy-rc

Hey @kmurphy-rc!

I'm picturing the same helper methods you have for any of your integration.

Here: https://github.com/RevenueCat/purchases-ios/blob/ce5be1b895f506186d0192027563b17c2d529379/Sources/Purchasing/Purchases/Attribution.swift

I asked to add the PostHog integration few weeks ago, I'm asking for the same thing but for Amplitude.

Thanks, Axel

alpennec avatar Feb 11 '25 18:02 alpennec

Ahh @alpennec, thanks for clarifying! That makes total sense - I'll share with the team.

kmurphy-rc avatar Feb 11 '25 23:02 kmurphy-rc

This seems to have been resolved by https://github.com/RevenueCat/purchases-ios/pull/5446. Closing this issue. Please let us know if you need anything else. Thanks for your contribution!

JayShortway avatar Oct 10 '25 14:10 JayShortway

Thanks @JayShortway, it was my PR 🙂

alpennec avatar Oct 10 '25 14:10 alpennec

Yes I know! That's what I meant with "contribution" 😄 Thank you!

JayShortway avatar Oct 10 '25 15:10 JayShortway