purchases-ios icon indicating copy to clipboard operation
purchases-ios copied to clipboard

Renable latest DocC

Open jamesrb1 opened this issue 1 year ago • 10 comments

DocC has fixed the issue, and this PR reverts our package files to use the plugin's latest version, as it was before.

Unsure if we need to check its output somehow, or how best to do that.

jamesrb1 avatar Sep 04 '24 18:09 jamesrb1

@RCGitBot please test

jamesrb1 avatar Sep 04 '24 18:09 jamesrb1

there are a couple of fastlane lanes that you can use to generate the docs and preview them, preview_docs and build_docs

aboedo avatar Sep 04 '24 20:09 aboedo

look for this:

https://revenuecat.github.io/purchases-ios-docs/5.0.0/documentation/revenuecat/purchases/offerings()

the description should be the one for the method, not "inherited" (TIL the current version is broken)

aboedo avatar Sep 04 '24 20:09 aboedo

here's a non-broken version for comparison

https://revenuecat.github.io/purchases-ios-docs/5.3.1/documentation/revenuecat/purchases/getofferings(completion:)/

aboedo avatar Sep 04 '24 20:09 aboedo

@jamesrb1 were you able to check?

aboedo avatar Sep 05 '24 22:09 aboedo

I'm unable to compile the docs on main and this branch because it's trying to use macOS instead of iOS. Trying to figure this out....

[16:43:08]: $ xcrun --sdk iphonesimulator --show-sdk-path
[16:43:08]: ▸ /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk
[16:43:08]: ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[16:43:08]: Step: swift build --target RevenueCat -Xswiftc -sdk -Xswiftc /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk -Xswiftc -target -Xswiftc arm64-apple-ios16.1-simulator -Xswiftc -emit-symbol-graph -Xswiftc -emit-symbol-graph-dir -Xswiftc .build
[16:43:08]: ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[16:43:08]: $ swift build --target RevenueCat -Xswiftc -sdk -Xswiftc /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk -Xswiftc -target -Xswiftc arm64-apple-ios16.1-simulator -Xswiftc -emit-symbol-graph -Xswiftc -emit-symbol-graph-dir -Xswiftc .build
[16:43:08]: ▸ warning: 'purchases-ios': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
[16:43:08]: ▸ /Users/jamesborthwick/GitHub/purchases-ios/RevenueCatUI/RevenueCatUIDev.xctestplan
[16:43:08]: ▸ Building for debugging...
[16:43:08]: ▸ [0/4] Write sources
[16:43:08]: ▸ [1/4] Copying Info.plist
[16:43:08]: ▸ [2/4] Copying PrivacyInfo.xcprivacy
[16:43:08]: ▸ [3/4] Write swift-version--58304C5D6DBC2206.txt
[16:43:11]: ▸ error: emit-module command failed with exit code 1 (use -v to see invocation)
[16:43:11]: ▸ [5/277] Emitting module RevenueCat
[16:43:11]: ▸ <unknown>:0: warning: using sysroot for 'MacOSX' but targeting 'iPhone'
[16:43:11]: ▸ /Users/jamesborthwick/GitHub/purchases-ios/Sources/Attribution/AttributionFetcher.swift:17:8: error: cannot load underlying module for 'UIKit'
[16:43:11]: ▸ import UIKit
[16:43:11]: ▸ ^
[16:43:11]: ▸ <module-includes>:1:9: note: in file included from <module-includes>:1:
[16:43:11]: ▸ #import "Headers/StoreKit.h"
[16:43:11]: ▸ ^
[16:43:11]: ▸ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/StoreKit.framework/Headers/StoreKit.h:13:9: note: in file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/System/Library/Frameworks/StoreKit.framework/Headers/StoreKit.h:13:
[16:43:11]: ▸ #import <StoreKit/SKCloudServiceSetupViewController.h>
[16:43:11]: ▸ ^

jamesrb1 avatar Sep 05 '24 23:09 jamesrb1

@aboedo I wasn't able to get it running locally using Xcode 15 and Xcode 14 (which the CI machine uses) won't run on Sonoma.... but I'm on my way to having the CI machine make the output available as an artifact, will finish this up tomorrow.

jamesrb1 avatar Sep 06 '24 04:09 jamesrb1

@jamesrb1 I'm a bit confused as to why we need to take care of this now, was it blocking a release?

aboedo avatar Sep 06 '24 18:09 aboedo

It's not blocking a release, but when you asked about it, I thought I should take a look. Most of the time I spent on this was after hours. I'll set it aside for now!

jamesrb1 avatar Sep 06 '24 21:09 jamesrb1

Converted back to draft as no longer in a mergable state - artifact output needs zipping and code needs tidying.

jamesrb1 avatar Sep 11 '24 15:09 jamesrb1