Migrate amazon & debugview modules to KTS
Motivation
- Migrate
amazon&debugviewmodules to KTS - Bump kover to 0.7.2 and remove the
afterEvaluatetasks. (refer to https://github.com/Kotlin/kotlinx-kover/issues/362)
@tonidero @JayShortway Do you have any ideas for passing the test workflow? 😄
Ugh, those Amazon tests are now failing with
Expected stackmap frame at this location.
I don't know what causes it, but I've seen it reported before: https://github.com/RevenueCat/purchases-kmp/issues/271
I think it's related to the Amazon dependency and JDK version, but I don't know why it's suddenly an issue. Maybe updating the dependency from 3.0.5 to 3.0.7 helps? (Although there's nothing mentioned in the changelog.)
Otherwise we can try setting -noverify in the :feature:amazon module, as suggested here.
@skydoves @tonidero This fixes Amazon tests for me locally: https://github.com/RevenueCat/purchases-android/pull/2327/commits/296e40e71588083e6a4a56b9e1c9c5bb8e19cded.
@JayShortway This (https://github.com/RevenueCat/purchases-android/commit/296e40e71588083e6a4a56b9e1c9c5bb8e19cded) fixed on my local device but it stills failed on CI 😞
@skydoves Hmm I don't think it's Amazon anymore. The failures are different this time.
-
test_cec_debugandtest_cec_releaseare variant incompatibilities. MaybematchingFallbackscan help here too? -
test_defaults_releaseseems to be Kover related, see this related comment.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 78.32%. Comparing base (579a2b9) to head (b6e7401).
:warning: Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2327 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 300 300
Lines 11126 11126
Branches 1551 1551
=======================================
Hits 8714 8714
Misses 1732 1732
Partials 680 680
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@JayShortway @tonidero Eventually it has passed! 🚀 Thank you so much for your support and patience!
@skydoves Awesome, thanks for persisting! 😄 Glad to get this in.