purchases-android icon indicating copy to clipboard operation
purchases-android copied to clipboard

[EXTERNAL] Fixes a typo in PaywallColor. (#1644) via @JayShortway

Open tonidero opened this issue 1 year ago • 1 comments

Contributed by @JayShortway in #1644

Motivation

There's a small typo in the docs of PaywallColor. #RRGGBBAA should have been #AARRGGBB, according to the docs of the underlying API being used (Color.parseColor()).

Regarding purchases-ios, parseColor in PaywallColor.swift does seem to follow the RRGGBBAA pattern, so the documentation is correct there. I couldn't find this API in the hybrids.

Resolves #1643

Description

The documentation is aligned with the documentation of the underlying API.

tonidero avatar Mar 14 '24 09:03 tonidero

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.44%. Comparing base (1538815) to head (e4d6b58). Report is 141 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1645   +/-   ##
=======================================
  Coverage   83.44%   83.44%           
=======================================
  Files         221      221           
  Lines        7476     7476           
  Branches     1050     1050           
=======================================
  Hits         6238     6238           
  Misses        827      827           
  Partials      411      411           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 14 '24 10:03 codecov[bot]

We're closing this since we actually changed the code in #1649 to accept #RRGGBBAA format, in order to keep compatibility with iOS.

tonidero avatar Mar 19 '24 14:03 tonidero

Nice, yeah that's the real fix! Makes sense to close this. I closed the issue (#1644) as well.

JayShortway avatar Mar 19 '24 14:03 JayShortway

Great thanks! 😋

tonidero avatar Mar 19 '24 14:03 tonidero

@JayShortway thanks again for flagging this! We hadn't noticed the discrepancy between both sides until you opened up the issue

aboedo avatar Mar 19 '24 20:03 aboedo

@aboedo Glad I could help! Before this I was not aware that there were different conventions for the alpha channel, so I learned something new 😄

JayShortway avatar Mar 20 '24 11:03 JayShortway