Reuben

Results 48 comments of Reuben

@edgarrmondragon Think I got the wrong end of the stick here and thought you were proposing `--[no]-install` as a global CLI option (i.e. `meltano --no-install ...`). > So having, for...

> 1. Users might expect to control this behavior in a similar way to other settings like `--log-level=...` > 2. Probably not too common, but users might have private/custom package...

> We can add a parameter to `get_pip_install_args` to add the option of raising the exception, and catch `EnvironmentVariableNotSetError`. Let me know what you think of this: https://github.com/meltano/meltano/pull/8482/commits/630eebfed4b45c127f336b9872ebaf031353852b

> @ReubenFrankel I think the only missing piece now is the global toggle. Wdyt? Yup, you happy with project setting name `auto_install` (configurable via `MELTANO_AUTO_INSTALL` env var) and the existing...

OK, I think this is almost there. A couple of things: - I renamed `PluginInstallReason.JIT` to `PluginInstallReason.AUTO` to align with other "auto-install" references - Following the previous point, since there...

> I agree, if it's not too complicated to change the log level of those messages depending on the command being called. Are you thinking `INFO` for `meltano install` (and...

After https://github.com/meltano/meltano/pull/8482/commits/bc45ecbfc504dc8a3f4a4bf84c6cbb7d51c68f26 and https://github.com/meltano/meltano/pull/8482/commits/bc428d3fa61d5b479f4ed8219c81c3f8840dbd57: ![image](https://github.com/meltano/meltano/assets/60552974/7e717683-9529-4f6a-a168-54c904ddaf1b) ![image](https://github.com/meltano/meltano/assets/60552974/5126d4b7-b0cc-4766-9853-128901a79b32)

Always a pleasure 😎

One option might be to not show the deprecation messages or put them behind a feature flag for now (like how `.lock` files were introduced before Meltano v2). Perhaps they...