s25client icon indicating copy to clipboard operation
s25client copied to clipboard

Fix bug #968 - Roads are no longer allowed to be in no-mans land or i…

Open Xellzul opened this issue 2 years ago • 4 comments

Fix bug #968 - Roads are no longer allowed to be in no-mans land or in border

The code is ugly so if you have any suggestions, feel free to fix it.

This should fix all problems, where roads were in places, where they shouldn't be.

If you need, I can provide few examples (savegames)

Xellzul avatar Apr 02 '24 18:04 Xellzul

@Flamefire Everything except the test should be addressed.

Xellzul avatar Apr 06 '24 10:04 Xellzul

@Flamefire Everything except the test should be addressed.

I see perfect thanks! Are you going to fix the test too or do you need help with that?

Flamefire avatar Apr 06 '24 10:04 Flamefire

@Flamefire Everything except the test should be addressed.

I see perfect thanks! Are you going to fix the test too or do you need help with that?

i will try to add the test on my own later today or tomorow

Xellzul avatar Apr 06 '24 12:04 Xellzul

@Flamefire So I did some more testing and found out one new bug. Border is considered as player territory.. Should be fixed in last commit

Screenshot 2024-04-10 151844

Xellzul avatar Apr 10 '24 14:04 Xellzul

I rebased your branch (fixing the conflict and squashing commits) and applied the remaining suggestion (see the last 3 commits)

Enabling automerge as CI should pass, if not I'll fix it ;-) Thanks a lot for hunting this down and fixing it!

Flamefire avatar Jul 07 '24 09:07 Flamefire