pisnes icon indicating copy to clipboard operation
pisnes copied to clipboard

added integer display option, very useful for gpi/pi-zero.

Open DSkywalk opened this issue 5 years ago • 9 comments

Hi this PR add a pixel perfect correction option to user CFG.

imagen

thanks :+1:

DSkywalk avatar Aug 29 '19 07:08 DSkywalk

Sorry Hugo ( @hhromic ), we meet in this PR from libretro.

could someone from retropie review these PRs?

Please check, the other PR on mame4all: https://github.com/RetroPie/mame4all-pi/pull/14

It would be great see this options available /officially/ :+1: It looks great on little LCD screens! :dancer:

Really thanks :)

DSkywalk avatar Sep 11 '19 19:09 DSkywalk

Hi @DSkywalk , no problem at all with pinging. I will ask around the devs about these PRs as I'm not very familiar with these emulators. I assume you tested your contributions thoroughly before submitting right? They look good.

hhromic avatar Sep 11 '19 19:09 hhromic

Yeah, these PRs just add a new option to removing any image-stretch.

And yes is tested a lot! We are using it (with some other guys in Telegram and reddit) from the first day I implemented it :tada: Is retropie open to new features or you preffer do not touch your ports? I do not want to disturb.

thanks again @hhromic :)

DSkywalk avatar Sep 11 '19 20:09 DSkywalk

Oh, sorry! the PR is already merged, sorry for the new changes. Just fixed some tabs.

DSkywalk avatar Sep 12 '19 06:09 DSkywalk

This PR still open :) Thanks @DSkywalk for your contributions, appreciated!

hhromic avatar Sep 12 '19 07:09 hhromic

@DSkywalk is this PR ready to merge?

hhromic avatar Sep 13 '19 11:09 hhromic

@hhromic I was think about backport hires mode (used in secret of mana), but it would be better made another PR because atm need more work. really thanks

DSkywalk avatar Sep 17 '19 19:09 DSkywalk

@DSkywalk hires mode sounds interesting! But yes, better submit in a separate PR when you have it done.

So, just to confirm, is this one (integer scaling) ready to merge then?

hhromic avatar Sep 18 '19 09:09 hhromic

Hi @hhromic, yes is ready to merge :+1:

I'm already working on a branch that adds a corrected hires mode, but as you said, it's time to make another new PR. Thanks again!

DSkywalk avatar May 10 '20 21:05 DSkywalk