Help is not fully themed when a dialog is opened

[cmitu]

trafficstars

Reported in https://retropie.org.uk/forum/topic/19733/emulation-station-quit-menu-helpsystem-font/2, a similar situation as the one reported in #144 (fixed in #146, but not completely). I'm adding this just so it doesn't get lost, could be something simple to contribute / fix.

[pjft]

Thanks for creating this.

For context on what I attempted at the time, and where I ran into issues.

The theme information is retrieved via the ViewController instance. However, for GuiComponent subclasses under es-core there is no shared context with ViewController or (as far as I could tell) any object from which I could reliable access it to retrieve the theme info. That’s kind of where I halted - I imagine that with a real-time debugger it could be easier to determine how to best access that information.

Some options that crossed my mind would be to: a) change the GuiComponent class to take the theme information as well. Seems to be a bit of an overkill. b) change the GuiComponent subclasses under es-core/src/guis to receive theme information. Not ideal either.

I’d love to hear from @jrassa (as he knows that part of the code better) and @tomaz82 (as he also has a good grasp on the ES architecture) before making a call here, as there’s a high likelihood that I won’t make the right one with the limited information and context I have.

Thanks.

[cmitu]

@pjft Thanks for taking a look. Option a) was my first idea of a fix, but for obvious reasons it wasn't so simple as in #146.

[pjft]

Well, it might be a simple fix with something obvious I overlooked (@jrassa was under the impression this should be fairly straightforward when I chatted with him, so it might be I’m missing something obvious). Let’s see what others suggest.

[rileyinman]

This still seems to be an issue, did any discussion past this end up happening?

[cmitu]

No, I don't think any discussions followed up on this issue.