EmulationStation icon indicating copy to clipboard operation
EmulationStation copied to clipboard

delete associated images when deleting game

Open moT01 opened this issue 8 years ago • 7 comments

I think this is a good spot to mention this, not sure --- After I deleted some games, I went to add some images the scraper couldn't find to some other games, and noticed the images of the games I removed were still there taking up space. Not a lot of space, but it would be nice if those images got deleted when someone deletes a game - just a thought

moT01 avatar Oct 16 '17 14:10 moT01

Thanks. This is a good idea in principle, and technically you can also use it for videos and marquee images.

A caveat: it's important to confirm that the image is not used by more games before deleting - for instance, the Arcade and FBA images and videos may be shared. It all depends on who organized the gamelists and artwork, and how.

Just a note.

pjft avatar Oct 16 '17 15:10 pjft

How are you deleting the games? Because I think there would be two separate ways to handle cleaning up dead images if game is deleted directly (deleting the file via SSH or wherever), or via emulationstation (via edit metadata > delete).

On the subject, I think the 'delete' function within emulationstation should be moved out of the 'edit metadata' screen, but that's another issue entirely ;)

dankcushions avatar Oct 16 '17 15:10 dankcushions

@dankcushions I was clearly reading this as "when deleting from the metadata editor screen", not manually :)

Curious about your angle on removing the "delete" function within ES from that menu, say more!

pjft avatar Oct 16 '17 15:10 pjft

Curious about your angle on removing the "delete" function within ES from that menu, say more!

i just think it should be moved somewhere else (the previous menu, i guess?), as it's nothing to do with metadata :) i guess someone just added a 'file delete' function to what previously just deleted the game from the xml? not sure.

dankcushions avatar Oct 16 '17 15:10 dankcushions

Ah, got it - keeping it in ES but elsewhere. I feel your pain on it feeling a bit out of place there :)

I think, from my recollection, that the "file delete" has always been there from Aloshi's time. (Just checked - yeah, that's where it came from). :)

I certainly don't have a strong opinion about it - the only times I use it is when I end up trying out a game that ends up not running (too slow, or incompatible). My concern with the option as a whole is that it is a somewhat "dangerous" (destructive) option, so in that sense, the further away from a potential incorrect use (i.e. kids or guests) the better.

Thanks for clarifying! :)

pjft avatar Oct 16 '17 15:10 pjft

I was deleting from the metadata menu, then manually going into the folders and deleted the images - only cause I was in there to add images for other games - otherwise I wouldn't have known they stayed there. The xml data could get removed/modified as well, but that's really not taking up much space. I would agree that the delete button could be better on the first options menu instead of the meta data menu but it works wherever, maybe add a password for deleting and for entering the settings area? Also, in the meta data menu it would be nice if the up button took you down to the bottom of the menu.

moT01 avatar Oct 16 '17 17:10 moT01

Also, in the meta data menu it would be nice if the up button took you down to the bottom of the menu.

Good idea :)

My concern with the option as a whole is that it is a somewhat "dangerous" (destructive) option, so in that sense, the further away from a potential incorrect use

Same we never really use this option, only for not working games, not really important to move it.

"when deleting from the metadata editor screen", not manually

In this case i think it can be really cool if ES can read the XML to get MEDIA PATH and remove them too. To save place.

Darknior avatar Jan 31 '18 23:01 Darknior