RAWeb icon indicating copy to clipboard operation
RAWeb copied to clipboard

Use first achievement as a reference for the average points per week

Open Zekromaster opened this issue 10 months ago • 3 comments

As discussed on the Discord, I altered the calculation of the average points per week so that instead of using the join date as a starting date, they use the date of the first achievement on the profile.

Zekromaster avatar Apr 18 '24 09:04 Zekromaster

@Zekromaster I like to be the one who marks my comments as resolved, otherwise I lose track of what I need to review when reapproaching a PR. Thanks for your understanding on this. For the time being, I've "unresolved" the given comments.

wescopeland avatar Apr 18 '24 16:04 wescopeland

@Zekromaster I like to be the one who marks my comments as resolved, otherwise I lose track of what I need to review when reapproaching a PR. Thanks for your understanding on this. For the time being, I've "unresolved" the given comments.

No problem, sorry for the confusion!

Zekromaster avatar Apr 18 '24 16:04 Zekromaster

I'm assuming all commits will be squashed before merge, so I'm just pushing another "apply code review" commit. I manually reverted what had to be reverted and tested squashing locally, now UserProfileMeta.php is the only file that would get touched by squash-merging.

Zekromaster avatar Apr 19 '24 15:04 Zekromaster