Reopened Tickets Still Showing Resolver

[televandalist]

Describe the bug If a ticket is reopened, it will still show the resolver.

To Reproduce https://retroachievements.org/ticketmanager.php?i=39049

Expected behavior Resolver should be blank

Screenshots

Additional context I guess in a way, it would be useful to see who had been working on a ticket, kind of like "participants" on a GitHub issue, but I doubt this is intended behavior.

[MSGoodman]

Looking at the code, I'm surprised this happened. In ticket.php's updateTicket there is this code, which should explicitly set the ResolvedByUserID to null if the ticket is moving out of the Resolved or Closed states:

    if ($ticketVal == TicketState::Resolved || $ticketVal == TicketState::Closed) {
        $resolvedFields = ", ResolvedAt=NOW(), ResolvedByUserID=$userID ";
    } elseif ($ticketData['ReportState'] == TicketState::Resolved || $ticketData['ReportState'] == TicketState::Closed) {
        $resolvedFields = ", ResolvedAt=NULL, ResolvedByUserID=NULL ";
    }

    $query = "UPDATE Ticket
              SET ReportState=$ticketVal $resolvedFields
              WHERE ID=$ticketID";

Do we have a newer example where someone hasn't already resolved the ticket?

[wescopeland]

@Jamiras With the latest round of tickets changes, might this be resolved?

[Jamiras]

I don't think anything in the latest round of ticket changes affected this behavior.

The audit log for the affected ticket shows a reopen happening in 2021, so I think this was actually fixed by #1258 (which happened after 2021, but before this issue was opened).