Indirect Pointer Code Notes causing code notes windows oddities/crashing

[redwizard42]

I've witnessed this in Dolphin and in RALibretro, but only today kind of pieced it together.

If I have indirect notes, every now and then the code notes window will decide to count them towards the current number of [filtered] notes. Happened several times today while I was messing around with Akalabeth on Amstrad CPC (caprice32 core) in RAlibretro. The game is kinda goofy in how it reallocates things as it adds things in (character creation, then loading a map, then quest data, then dungeon data) which pushes the player data further and further down as it adds things 'in between' game session data and the player data. In any case, the pointer changes rapidly as the game loads in new things that it needs to track in various situations.

In any case, seems like after awhile, the code note window sometimes picks up the indirect notes and will show a total like 23/15. Filtering doesn't seem to be required to reproduce this, and it doesn't seem like the code note window has to be open to have this happen. I've opened the code notes window into this kind of state (without ever having opened it since application launch) and other times I've had it happen after the code note window has been open awhile.

If I click Reset or Filter at all when it is in this state, I'll get an fatal error with an Abort/Retry/Ignore dialog. Regardless of choice, the application terminates without generating any sort of crash dump file, etc.