RAIntegration icon indicating copy to clipboard operation
RAIntegration copied to clipboard

Add shift-click feature on memory view to put focus on pointed address

Open Vancleeff opened this issue 1 year ago • 4 comments

Enhanced user experience by providing a convenient way to navigate to specific pointed memory addresses

Vancleeff avatar Apr 22 '24 01:04 Vancleeff

Thank you for the review @Jamiras, very helpful ! I made some correction and pushed everything, I'm not sure if the tests are enough for this usecase or if I need to add more console context.

Vancleeff avatar Apr 26 '24 22:04 Vancleeff

Thanks @Jamiras ! I changed the logic a bit by adding a mask for more complex pointer which are not converted into real addresses when using ByteAddressFromRealAddress.

Example : PSX pointer like 0x80012345 are now masked based on the pConsoleContext.MaxAddress size and then converted with ByteAddressFromRealAddress to point towards 0x12345 address.

I adapted the tests accordingly.

Vancleeff avatar Apr 28 '24 22:04 Vancleeff

Are you still working on these? Three of the four PRs have CI failures that need to be addressed, and the fourth has open comments to resolve.

Jamiras avatar May 18 '24 15:05 Jamiras

Hello @Jamiras ! Yes, I had to finish my second set, it's now on pending review so I will switch back on these PRs !

Vancleeff avatar May 20 '24 14:05 Vancleeff