Icons and ini

[basxto]

It looks like the icons are hardcoded to

`pwd`/resources/Icon*.png

and don’t use ini

Might get fixed by https://github.com/Retera/WarsmashModEngine/pull/37

[Retera]

I recall this may be an issue with LibGDX itself. Perhaps in the short term until it is fixed, we could add a failsafe so that missing icons never causes the program to fail to load, since most users are unlikely to care about the icons?

[basxto]

But #37 really fixes it with turning

config.addIcon("resources/Icon16.png", Files.FileType.Internal);

into

config.addIcon(codebase.getFile("resources/Icon16.png").getAbsolutePath(), Files.FileType.Internal);

And it should also prevent crashes from missing icons since it’s wrapped with a try-catch.

The only issue with he PR is that it also changed the README.

Edit: I only read your

Looking again at the current state of this pull request, the DesktopLauncher changes seem fairly good in general

after the forcepush, but it seems the issue with .getAbsolutePath() persists. Though is there a better way? At least this way should also allow to load it from mpq files, right?

I don’t see it getting copied on my system, though it wouldn’t be a problem for me personally since it likely will be copied to file system located in RAM.

On my system even the icons in resources are only symbolic links to locations where it can be used as system icon for a .desktop file later:

warsmash-git /usr/share/icons/hicolor/128x128/apps/warsmash.png
warsmash-git /usr/share/icons/hicolor/16x16/apps/warsmash.png
warsmash-git /usr/share/icons/hicolor/32x32/apps/warsmash.png
warsmash-git /usr/share/icons/hicolor/64x64/apps/warsmash.png