redmine_issue_checklist icon indicating copy to clipboard operation
redmine_issue_checklist copied to clipboard

Can not delete last Checklist item.

Open atopcu opened this issue 9 years ago • 1 comments

Hi,

I am deleting all checklist items in issue edit mode. All checklist items come back after save the issue. If I left one of them in same scenario, it is deleting all other, no problem.

Environment: Redmine version 3.1.3.stable.15012 Ruby version 2.0.0-p481 (2014-05-08) [x86_64-linux] Rails version 4.2.5 Environment production Database adapter Mysql2

Have a nice day!

atopcu avatar May 19 '16 17:05 atopcu

We were able to fix this issue with this simple patch:

diff --git a/init.rb b/init.rb
index 2762b0d..f3c410a 100644
--- a/init.rb
+++ b/init.rb
@@ -21,7 +21,7 @@ Redmine::Plugin.register :redmine_issue_checklist do
     map.project_module :issue_tracking do |map|
       map.permission :view_checklists, {}
       map.permission :done_checklists, { issue_checklist: :done }
-      map.permission :edit_checklists, { issue_checklist: :delete, issue_checklist: :done }
+      map.permission :edit_checklists, { issue_checklist: [:delete, :done] }
     end
   end

diff --git a/lib/redmine_issue_checklist/hooks/model_issue_hook.rb b/lib/redmine_issue_checklist/hooks/model_issue_hook.rb
index 9ae0d54..0c7509d 100644
--- a/lib/redmine_issue_checklist/hooks/model_issue_hook.rb
+++ b/lib/redmine_issue_checklist/hooks/model_issue_hook.rb
@@ -37,7 +37,7 @@ module RedmineIssueChecklist
       def save_checklist_to_issue(context, create_journal)
         issue = context[:issue]
         checklist_items = context[:params] && context[:params][:check_list_items]
-        issue.update_checklist_items(checklist_items, create_journal) if issue && checklist_items
+        issue.update_checklist_items(checklist_items, create_journal) if issue
       end

     end

max-arnold avatar Apr 10 '17 03:04 max-arnold