jdiameter icon indicating copy to clipboard operation
jdiameter copied to clipboard

Memory leak in ServerRfSessionImpl

Open ddijak opened this issue 6 years ago • 1 comments

@Override public void sendAccountAnswer(RfAccountingAnswer accountAnswer) throws InternalException, IllegalStateException, RouteException, OverloadException { try { session.send(accountAnswer.getMessage()); /* TODO: Need to notify state change... if (isStateless() && isValid()) { session.release(); } */ } catch (IllegalDiameterStateException e) { throw new IllegalStateException(e); } }

After sending the answer, the sessions never gets released (beacuse its commented) and it causes memory leak in the long run.

ddijak avatar Jan 12 '18 09:01 ddijak

Hi @skymania ! 👋 Thanks for raising the issue!

Would you like to have a go at submitting a Pull Request for fixing this issue? If you need any help on the process, our Open Source Playbook might be of some help.

Please let me know if there's anything else you need.

gsaslis avatar Jan 25 '18 08:01 gsaslis