jain-sip icon indicating copy to clipboard operation
jain-sip copied to clipboard

incomingMessageChannel is not updated

Open Monika-Rajendran-97 opened this issue 1 year ago • 0 comments

In TLSMessageProcessor class, in run() method, below line creates object to TLSMessageChannel TLSMessageChannel newChannel = new TLSMessageChannel(newsock, sipStack, this, "TLSMessageChannelThread-" + nConnections);

which in turn creates a thread and start it in constructor itself, which is not good practice since as most of the time, it will end up with an escaped this reference, either explicitly or implicitly.

Because of this, incomingMessageChannel map is not updated with values.

Screenshot 2023-04-20 at 4 52 35 PM Screenshot 2023-04-20 at 4 54 16 PM

Monika-Rajendran-97 avatar Apr 20 '23 11:04 Monika-Rajendran-97