jain-sip
jain-sip copied to clipboard
RestComm
Update log4j lib version
@valliman we are planning to fully mavenize the project, and update thirdparty Libs. On this context, updating log4j to something more new would be certainly desirable. Right now we are using log4j-1.2.15.jar, and we are looking into using any log4j2 build.
This effort would include to check any compilation issues due to API deprecation problems, and retesting the whole TCK and testsuite.
If you are free to help, you are more than welcome. wdyt?
@jaimecasero
I would suggest to update to log4j2 as well. How would you like to procede with the logging facade. Is it fine to remove it and to reference directly to the log4j api or do you want to reference to a logging facade like slf4j? Or is such a change not desired at all and the existing logging facade has to be kept?
@valliman As you can see, JAIN SIP defines its own facade at https://github.com/RestComm/jain-sip/blob/master/src/gov/nist/core/StackLogger.java . This is not particurlarly good, but changing the facade as it is now would imply too many changes. I would prefer to enrich this facade with some convenient new methods to tkae advantage of possible impl features ( like parameterized logging)
Basically my idea was to upgrade the lib, check any issues on facade impl for log4j at https://github.com/RestComm/jain-sip/blob/master/src/gov/nist/core/CommonLoggerLog4j.java , and then retest the whole testSuite to check if there is some problem
wdyt? does it sound like plan?
Also worth mentioning the preferrable usage of AsyncAppender from version 2.6 http://logging.apache.org/log4j/2.x/manual/async.html#Performance
Did you already made up some thoughts how to continue here. Is Java 1.5 compability still a "must have"?
well from log4j2 web site i can see 1.7 is required from version 2.3. We need to support some old versions of jboss5 which may not support 1.7. So we were thinking about looking into 1.6 as new jain sip req, and allowing log4j2 at the same time. At the expense of downgrading log4j from 2.8 to <2.3
wdty? could you try that and see all works with <2.3
