Restcomm-Connect icon indicating copy to clipboard operation
Restcomm-Connect copied to clipboard

Published 20 hours ago • verified publisher icon RestComm

Add filters for IncomingPhoneNumber dashboard ui Issue #1867

Open muhammadbilal19 opened this issue 7 years ago • 4 comments

Please have a look at the changes related to remote filtering for IncomingPhoneNumber on dashboard.

muhammadbilal19 avatar Jun 20 '17 10:06 muhammadbilal19

Thanks @muhammadbilal19 @ammendonca can you help review this one ?

deruelle avatar Jul 12 '17 10:07 deruelle

Hi @muhammadbilal19

Thanks for the PR, sorry for the long wait for review.

I'm pasting a screenshot of how it looks after your fix (please try to do this for PRs which change the UI): image

I think we should keep the same UI/UX, with a single search field that can match either the number or the friendly name, WDYT ? Also, it would be great if the filtering was happening as the user is typing. In summary, keep as it was, with the remote filtering instead of local and ignoring the enter key press.

WDYT ?

cc @ipsilantide

ammendonca avatar Jul 18 '17 12:07 ammendonca

Thanks @ammendonca sure i will add screenshots next time if i change any UI.

Sounds good to me if we can disable enter key and use only remote filters it looks good to me. As we already implemented pagination and we are not loading all the records on UI so local filtering is useless i guess. If everyone is happy with this i will update the PR with these changes?

muhammadbilal19 avatar Jul 18 '17 21:07 muhammadbilal19

+1 to filtering while the user is typing

ipsilantide avatar Jul 19 '17 09:07 ipsilantide