Restcomm-Connect
Restcomm-Connect copied to clipboard
Pagination for client api and dashboard #2154
Pagination is added for both api and dashboard. Feel free to have a look and let me know if you have any comments.
Thanks @muhammadbilal19. @gvagenas can you please review ?
Just a quick note, I've tested this PR but it didn't compile with missing files, eg org.restcomm.connect.dao.entities.ClientFilter. Please check if you missed adding any files.
@ammendonca Sorry i miss this file just commit please check now. Secondly just wanted to mention that UI issues which you mention for PR #2211 might also be available in this PR because everywhere in the restcomm application pagination logic is same. Once i fix that issue i will commit that for both PR you can check give your comments if you see any other issue.
Thanks @muhammadbilal19, now it compiled properly. Yes, I have noticed that the UI logic was the same, so I was expecting the issue to exist possibly in other places as well. Please feel free to create a separate Issue/PR to handle this in other places, not to overload this PR with unrelated changes.
Yes @ammendonca just see this issue exists in logs-calls ui as well. I think every place where we used pagination this issue exists. I will create separate issues for all the pages.
@ammendonca items per page selection and sorting issue is fixed for this PR.
@gvagenas i added few fixes which we found in #2189. So so far ClientDao and ClientEndpoint Test are passing feel free have a look when you have some time and let me know with your comments.
@ammendonca @gvagenas are you able to review that PR so far?