Responsive icon indicating copy to clipboard operation
Responsive copied to clipboard

Move close button?

Open svanlaere opened this issue 7 years ago • 7 comments

Perhaps not a real issue, but consider the markup for displaying alerts: http://responsivebp.com/css/alerts/

Assuming that screenreaders read the button first instead of the more important message: Would it not make more sence to move the close button after the desired message?

svanlaere avatar Aug 25 '17 09:08 svanlaere

@svanlaere Interesting question; I think you might well be correct. I shall check and if this is the case will change the content order to match read order.

JimBobSquarePants avatar Aug 25 '17 12:08 JimBobSquarePants

How can I contact you by e-mail?

svanlaere avatar Aug 25 '17 23:08 svanlaere

@svanlaere I'd like to keep all conversations public if that's ok. More helpful for others.

JimBobSquarePants avatar Sep 21 '17 12:09 JimBobSquarePants

@svanlaere I've updated this in the v5-dev branch. The button can now be placed before and after.

JimBobSquarePants avatar Oct 27 '17 04:10 JimBobSquarePants

So can this issue be closed now?

adityaraute avatar Oct 11 '21 15:10 adityaraute

Not until I release the thing I'd say.

JimBobSquarePants avatar Dec 08 '21 01:12 JimBobSquarePants

Been a long time :D

adityaraute avatar Dec 09 '21 09:12 adityaraute